feat(route53-patterns): `HttpsRedirect` use `Distribution` as the default CloudFront distribution (under feature flag) #34312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

phuhung273 wants to merge 1 commit into aws:main from phuhung273:httpsredirect-use-distribution

Contributor

phuhung273 commented Apr 30, 2025 •

edited

Loading

Issue # (if applicable)

Closes #31546

Reason for this change

CloudFrontWebDistribution is deprecated

Description of changes

HttpsRedirect use Distribution instead of deprecated CloudFrontWebDistribution under feature flag

Please check template comments for explanation on each removed param:

Most of them are safe to remove since most are default
ForwardedValues is deprecated and replaced by CachePolicyId

Description of how you validated changes

Unit + Integ

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation requested a review from a team

April 30, 2025 05:47

github-actions bot added bug effort/medium p2 star-contributor labels

aws-cdk-automation added the pr/needs-community-review label

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                   ],

                   "Comment": "Redirect to aws.amazon.com from integ-same-region.example.com",

                   "DefaultCacheBehavior": {

                    "AllowedMethods": [

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

Lines 1051 to 1053 in db62c5f

    
              * @default AllowedMethods.ALLOW_GET_HEAD 
        
              */ 
        
             readonly allowedMethods?: AllowedMethods;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                     "GET",

                     "HEAD"

                    ],

                    "CachedMethods": [

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

Lines 1058 to 1060 in db62c5f

    
              * @default CachedMethods.CACHE_GET_HEAD 
        
              */ 
        
             readonly cachedMethods?: CachedMethods;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                   "IPV6Enabled": true,

                   "Origins": [

                    {

                     "ConnectionAttempts": 3,

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/origin.ts

Lines 91 to 93 in db62c5f

    
              * @default 3 
        
              */ 
        
             readonly connectionAttempts?: number;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                   "Origins": [

                    {

                     "ConnectionAttempts": 3,

                     "ConnectionTimeout": 10,

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/origin.ts

Lines 84 to 86 in db62c5f

    
              * @default Duration.seconds(10) 
        
              */ 
        
             readonly connectionTimeout?: Duration;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                     "CustomOriginConfig": {

                      "HTTPPort": 80,

                      "HTTPSPort": 443,

                      "OriginKeepaliveTimeout": 5,

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront-origins/lib/vpc-origin.ts

Lines 36 to 38 in db62c5f

    
              * @default Duration.seconds(5) 
        
              */ 
        
             readonly keepaliveTimeout?: cdk.Duration;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                      "HTTPSPort": 443,

                      "OriginKeepaliveTimeout": 5,

                      "OriginProtocolPolicy": "http-only",

                      "OriginReadTimeout": 30,

Contributor Author

phuhung273 Apr 30, 2025

aws-cdk/packages/aws-cdk-lib/aws-cloudfront-origins/lib/vpc-origin.ts

Lines 25 to 27 in db62c5f

    
              * @default Duration.seconds(30) 
        
              */ 
        
             readonly readTimeout?: cdk.Duration;

phuhung273 commented

View reviewed changes

...integ.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json

    
                    ],

                    "CachePolicyId": "658327ea-f89d-4fab-a63d-7e88639e58f6",

                    "Compress": true,

                    "ForwardedValues": {

Contributor Author

phuhung273 Apr 30, 2025

Deprecated https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-defaultcachebehavior.html#cfn-cloudfront-distribution-defaultcachebehavior-forwardedvalues

Replaced by CachePolicyId

github-actions bot mentioned this pull request

Monthly PR metrics report #34324

Closed

phuhung273 force-pushed the httpsredirect-use-distribution branch from 612936b to 01f9b06 Compare

May 17, 2025 05:07

phuhung273 force-pushed the httpsredirect-use-distribution branch from 01f9b06 to a84f437 Compare

June 8, 2025 02:02

phuhung273 had a problem deploying to test-pipeline

June 8, 2025 02:03

— with

GitHub Actions Failure

phuhung273 force-pushed the httpsredirect-use-distribution branch from a84f437 to 3dd07d0 Compare

June 18, 2025 15:10

phuhung273 had a problem deploying to test-pipeline

June 18, 2025 15:11

— with

GitHub Actions Failure

phuhung273 force-pushed the httpsredirect-use-distribution branch from 3dd07d0 to 9bcfc77 Compare

July 5, 2025 09:30

phuhung273 had a problem deploying to test-pipeline

July 5, 2025 09:31

— with

GitHub Actions Failure

phuhung273 force-pushed the httpsredirect-use-distribution branch from 9bcfc77 to 58ea849 Compare

July 19, 2025 02:43

phuhung273 had a problem deploying to test-pipeline

July 19, 2025 02:43

— with

GitHub Actions Failure

phuhung273 force-pushed the httpsredirect-use-distribution branch from 58ea849 to fa0caaa Compare

July 27, 2025 02:25

phuhung273 had a problem deploying to test-pipeline

July 27, 2025 02:26

— with

GitHub Actions Failure

Collaborator

aws-cdk-automation commented Jul 27, 2025

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: fa0caaa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


          feat(route53-patterns): HttpsRedirect use Distribution as the default…

b8ac8b1

… CloudFront distribution (under feature flag)

phuhung273 force-pushed the httpsredirect-use-distribution branch from fa0caaa to b8ac8b1 Compare

September 20, 2025 22:06

phuhung273 requested a deployment to test-pipeline

September 20, 2025 22:07

— with

GitHub Actions Waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug effort/medium p2 pr/needs-community-review star-contributor