Skip to content

Conversation

joostvanderborg
Copy link
Contributor

The event notification filtering documentation links were outdated. This PR updates the links to event notification filtering in the relevant methods docstrings.

Closes #34277

Reason for this change

The event notification filtering documentation links were outdated.

Description of changes

Changes only to the URL in docstrings.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Updates the links to event notification filtering in the relevant
methods.
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 28, 2025 17:58
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Apr 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 28, 2025
@kaizencc kaizencc changed the title docs: update link for s3 event notification filter docs(s3): update link for s3 event notification filter Apr 30, 2025
kaizencc
kaizencc previously approved these changes Apr 30, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 30, 2025
Copy link
Contributor

mergify bot commented Apr 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Apr 30, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed kaizencc’s stale review April 30, 2025 18:58

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 844ae79
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 30, 2025
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. pls let this merge on its own, otherwise my review gets invalidated

Copy link
Contributor

mergify bot commented Apr 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 575efd8 into aws:main Apr 30, 2025
17 of 19 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3: Incorrect @see references in bucket.ts

3 participants