Skip to content

Conversation

@wafuwafu13
Copy link
Contributor

Issue # (if applicable)

#34218 (comment)

Reason for this change

Currently, EKS integration tests use v1.24 as default version which is no longer supported.

export function getClusterVersionConfig(scope: Construct, version?: eks.KubernetesVersion) {
const _version = version ?? eks.KubernetesVersion.V1_24;

Description of changes

Update default Kubernetes version from v1.24 to v1.32 in integration tests

Describe any new or updated permissions being added

None

Description of how you validated changes

Pass integration tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2025 08:03
@github-actions github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Apr 26, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@wafuwafu13 wafuwafu13 changed the title tests(eks): remove eks.KubernetesVersion.V1_24 as default version in integration tests test(eks): remove eks.KubernetesVersion.V1_24 as default version in integration tests Apr 26, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 26, 2025 08:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 26, 2025
paulhcsun
paulhcsun previously approved these changes May 2, 2025
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping to keep these updated!

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Contributor

Ah it looks like there are some merge conflicts. Would you be able to re-run these to update the snapshots?

@mergify mergify bot dismissed paulhcsun’s stale review May 2, 2025 20:24

Pull request has been modified.

@wafuwafu13
Copy link
Contributor Author

wafuwafu13 commented May 2, 2025

Thank you for checking. Conflicts are resolved!

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @wafuwafu13!

@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 5, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented May 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7b464ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4426784 into aws:main May 5, 2025
13 of 15 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants