Skip to content

chore(cognito-identitypool): make role attachment resource public #34234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

chore(cognito-identitypool): make role attachment resource public #34234

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b955301
Publicize role attachment
Apr 23, 2025
db0a27b
Merge branch 'main' into public-attachment
Leo10Gama Apr 23, 2025
4e2ffce
Let it set to CFN instead of intermediary class
Apr 23, 2025
ce4f117
Merge branch 'public-attachment' of https://github.com/Leo10Gama/aws-…
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/aws-cdk-lib/aws-cognito-identitypool/lib/identitypool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ export class IdentityPool extends Resource implements IIdentityPool {
/**
* Role Provider for the default Role for authenticated users
*/
private readonly roleAttachment: IdentityPoolRoleAttachment;
public readonly roleAttachment: CfnIdentityPoolRoleAttachment;

/**
* List of Identity Providers added in constructor for use with property overrides
Expand Down Expand Up @@ -500,7 +500,7 @@ export class IdentityPool extends Resource implements IIdentityPool {
authenticatedRole: this.authenticatedRole,
unauthenticatedRole: this.unauthenticatedRole,
roleMappings: props.roleMappings,
});
}).resource;

Array.isArray(this.roleAttachment);
}
Expand Down Expand Up @@ -589,6 +589,11 @@ class IdentityPoolRoleAttachment extends Resource implements IIdentityPoolRoleAt
*/
public readonly identityPoolId: string;

/**
* The Identity Pool Role Attachment CFN resource.
*/
public readonly resource: CfnIdentityPoolRoleAttachment;

constructor(scope: Construct, id: string, props: IdentityPoolRoleAttachmentProps) {
super(scope, id);
// Enhanced CDK Analytics Telemetry
Expand All @@ -604,7 +609,7 @@ class IdentityPoolRoleAttachment extends Resource implements IIdentityPoolRoleAt
if (mappings) {
roleMappings = this.configureRoleMappings(...mappings);
}
new CfnIdentityPoolRoleAttachment(this, 'Resource', {
this.resource = new CfnIdentityPoolRoleAttachment(this, 'Resource', {
identityPoolId: this.identityPoolId,
roles,
roleMappings,
Expand Down
Loading