-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(rds): support auto-pause configuration for Aurora Serverless v2 #34173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is fine, but left very trivial comments.
@go-to-k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re #34173 (comment), I have reached out to the RDS team to ask about their engine support plan for auto-pause.
Blocking this PR while I await their response.
@vishaalmehrishi Thanks for review. If we can add the |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments about setting the supported feature configuration in a more maintainable way.
Pull request has been modified.
@vishaalmehrishi |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32280.
Closes #32563.
Reason for this change
Aurora Serverless v2 DB instances can specify the time period of inactivity before auto-pause.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2-auto-pause.html
Description of changes
Added the
serverlessV2AutoPauseDuration
prop forDatabaseCluster
.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests and an integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license