Skip to content

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Apr 17, 2025

Issue # (if applicable)

Closes #32280.
Closes #32563.

Reason for this change

Aurora Serverless v2 DB instances can specify the time period of inactivity before auto-pause.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2-auto-pause.html

Description of changes

Added the serverlessV2AutoPauseDuration prop for DatabaseCluster.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added unit tests and an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 17, 2025 03:57
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 17, 2025
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, but left very trivial comments.

@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 17, 2025
@Tietew
Copy link
Contributor Author

Tietew commented Apr 18, 2025

@go-to-k
Thanks for review! I've pushed updates.

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 18, 2025
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re #34173 (comment), I have reached out to the RDS team to ask about their engine support plan for auto-pause.

Blocking this PR while I await their response.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 20, 2025
@Tietew
Copy link
Contributor Author

Tietew commented May 22, 2025

@vishaalmehrishi Thanks for review.
I understand ClusterEngine validates whether the specified engine version supports s3Import and s3Export features.

If we can add the serverlessV2AutoPause feature flag like s3Import and s3Export,
It will not depend AWS's support plan.

@vishaalmehrishi vishaalmehrishi self-assigned this May 22, 2025
@mergify mergify bot dismissed vishaalmehrishi’s stale review May 30, 2025 07:13

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 30, 2025
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments about setting the supported feature configuration in a more maintainable way.

@mergify mergify bot dismissed vishaalmehrishi’s stale review June 3, 2025 02:41

Pull request has been modified.

@Tietew
Copy link
Contributor Author

Tietew commented Jun 3, 2025

@vishaalmehrishi
Pushed. How about this change?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 3, 2025
@mergify mergify bot dismissed vishaalmehrishi’s stale review June 4, 2025 02:38

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 4, 2025
Copy link
Contributor

mergify bot commented Jun 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 13636d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2c55c28 into aws:main Jun 10, 2025
16 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2025
@Tietew Tietew deleted the rds-aurora-autopause branch June 11, 2025 03:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

5 participants