Skip to content

feat(pipes-targets): add SNS #34159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 13, 2025
Merged

feat(pipes-targets): add SNS #34159

merged 8 commits into from
May 13, 2025

Conversation

@msambol
Copy link
Contributor

@msambol msambol commented Apr 16, 2025 •
edited
Loading

Issue # (if applicable)

N/A

Reason for this change

Add SNS as a Pipes target.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 16, 2025 01:51
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Apr 16, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 16, 2025
nmussy
nmussy reviewed Apr 20, 2025
View reviewed changes
nmussy
nmussy suggested changes Apr 20, 2025
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small coverage concern 👍

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 20, 2025
@msambol msambol force-pushed the pipes-targets-sns branch from 786449e to d79d11a Compare April 20, 2025 16:37
nmussy
nmussy approved these changes Apr 20, 2025
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 20, 2025
@github-actions github-actions bot mentioned this pull request May 1, 2025
Closed
samson-keung
samson-keung previously requested changes May 12, 2025
View reviewed changes
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2025
@mergify mergify bot dismissed samson-keung’s stale review May 12, 2025 18:54

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2025
samson-keung
samson-keung previously approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thank you!

@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2025
@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #34159 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify bot dismissed samson-keung’s stale review May 12, 2025 22:20

Pull request has been modified.

samson-keung
samson-keung previously approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving due to merge from main

@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed samson-keung’s stale review May 13, 2025 00:40

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 13, 2025
@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 13, 2025
@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b063b36
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2f846b3 into aws:main May 13, 2025
14 of 15 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
@msambol msambol deleted the pipes-targets-sns branch May 13, 2025 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@nmussy nmussy nmussy approved these changes

@samson-keung samson-keung samson-keung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samson-keung samson-keung

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msambol @aws-cdk-automation @nmussy @samson-keung