Skip to content

Conversation

wimlewis-amazon
Copy link
Contributor

Issue # (if applicable)

None

Reason for this change

Attribute documentation was incorrect (pasted from the documentation for principalStatements, probably)

Description of changes

Updated the documentation comment to agree with the contents of the attribute.

Describe any new or updated permissions being added

None. Has no effect on permissions or on the synthesized stacks.

Description of how you validated changes

Non-behavioral change.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 14, 2025 22:13
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@samson-keung samson-keung changed the title Correct documentation of Grant#resourceStatements doc(iam): correct documentation of Grant#resourceStatements Apr 15, 2025
@samson-keung samson-keung changed the title doc(iam): correct documentation of Grant#resourceStatements doc(iam): correct documentation of Grant.resourceStatements Apr 15, 2025
@samson-keung samson-keung changed the title doc(iam): correct documentation of Grant.resourceStatements docs(iam): correct documentation of Grant.resourceStatements Apr 15, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 15, 2025 05:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3aeb8b1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b9758f2 into aws:main Apr 15, 2025
14 of 15 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2025
@wimlewis-amazon wimlewis-amazon deleted the patch-1 branch April 22, 2025 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants