feat(ec2): throw ValidationErrors instead of untyped Errors #34127

tttol · 2025-04-13T01:19:46Z

Issue # (if applicable)

Relates to #32569

Reason for this change

Untyped Errors are not recommended.

Description of changes

Change Error to ValidationError / UnscopedValidationError

Describe any new or updated permissions being added

None

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

tttol · 2025-04-13T01:20:08Z

Exemption Request: This PR did only refactoring.

aws-cdk-automation

(This review is outdated)

codecov · 2025-04-13T01:28:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (74cbe27) to head (5da42f7).
Report is 30 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #34127   +/-   ##
=======================================
  Coverage   83.98%   83.99%           
=======================================
  Files         120      120           
  Lines        6976     6977    +1     
  Branches     1178     1178           
=======================================
+ Hits         5859     5860    +1     
  Misses       1005     1005           
  Partials      112      112

Flag	Coverage Δ
suite.unit	`83.99% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`83.99% <ø> (+<0.01%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tttol · 2025-04-13T12:16:46Z

packages/aws-cdk-lib/aws-ec2/lib/volume.ts


    if (props.snapshotId && !Token.isUnresolved(props.snapshotId) && !/^snap-[0-9a-fA-F]+$/.test(props.snapshotId)) {
-      throw new Error('`snapshotId` does match expected pattern. Expected `snap-<hexadecmial value>` (ex: `snap-05abe246af`) or Token');
+      throw new ValidationError('`snapshotId` does not match expected pattern. Expected `snap-<hexadecmial value>` (ex: `snap-05abe246af`) or Token', this);


fix message

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

paulhcsun

Thanks for making these changes!

paulhcsun · 2025-04-14T21:10:49Z

@Mergifyio update

mergify · 2025-04-14T21:11:02Z

update

☑️ Nothing to do

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

packages/aws-cdk-lib/aws-ec2/lib/instance.ts

Pull request has been modified.

paulhcsun · 2025-04-14T22:13:13Z

@Mergifyio update

mergify · 2025-04-14T23:09:54Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/enum-auto-updater.yml without workflows permission

mergify · 2025-04-14T23:09:56Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-14T23:13:56Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-14T23:38:13Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Pull request has been modified.

paulhcsun

Sorry, mergify is not playing nice. hopefully this time it will work.

paulhcsun · 2025-04-15T18:10:04Z

@Mergifyio update

mergify · 2025-04-15T18:10:13Z

update

☑️ Nothing to do

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

mergify · 2025-04-15T18:40:08Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-15T18:43:49Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-15T18:53:40Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

tttol · 2025-04-15T20:04:59Z

@paulhcsun
The Mergify bug seems to be resolved. Should we merge main into my branch? 💭
#34152

paulhcsun · 2025-04-15T21:38:48Z

@Mergifyio update

mergify · 2025-04-15T21:38:55Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/security-guardian.yml without workflows permission

Pull request has been modified.

paulhcsun · 2025-04-15T21:40:47Z

@Mergifyio requeue

mergify · 2025-04-15T21:40:51Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

aws-cdk-automation · 2025-04-15T22:09:34Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 92736a5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-15T22:09:57Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-15T22:10:16Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

tttol added 4 commits April 12, 2025 05:50

remove Error

1934ddf

fix

b12b22a

remove Error

24da4b8

chore

4acbb26

tttol requested a review from a team as a code owner April 13, 2025 01:19

aws-cdk-automation requested a review from a team April 13, 2025 01:19

github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Apr 13, 2025

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 13, 2025

aws-cdk-automation previously requested changes Apr 13, 2025

View reviewed changes

tttol added 2 commits April 13, 2025 15:31

empty commit

722095b

fix test error

5da42f7

tttol commented Apr 13, 2025

View reviewed changes

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 13, 2025

shikha372 assigned paulhcsun Apr 14, 2025

Merge branch 'main' into ec2-validation-error

ef4afb1

paulhcsun added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 14, 2025

paulhcsun previously approved these changes Apr 14, 2025

View reviewed changes

paulhcsun reviewed Apr 14, 2025

View reviewed changes

packages/aws-cdk-lib/aws-ec2/lib/instance.ts Outdated Show resolved Hide resolved

Update packages/aws-cdk-lib/aws-ec2/lib/instance.ts

9d3276a

Merge branch 'main' into ec2-validation-error

2558a8c

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 14, 2025

Merge branch 'main' into ec2-validation-error

318b289

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 15, 2025

Merge branch 'main' into ec2-validation-error

4c9aeb0

paulhcsun previously approved these changes Apr 15, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 15, 2025

Merge branch 'main' into ec2-validation-error

92736a5

paulhcsun approved these changes Apr 15, 2025

View reviewed changes

mergify bot merged commit 93313dd into aws:main Apr 15, 2025
16 of 17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2025

tttol deleted the ec2-validation-error branch April 27, 2025 07:46

feat(ec2): throw ValidationErrors instead of untyped Errors #34127

feat(ec2): throw ValidationErrors instead of untyped Errors #34127

Uh oh!

Conversation

tttol commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

tttol commented Apr 13, 2025

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tttol Apr 13, 2025

Choose a reason for hiding this comment

Uh oh!

paulhcsun left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun commented Apr 14, 2025

Uh oh!

mergify bot commented Apr 14, 2025

☑️ Nothing to do

Uh oh!

Uh oh!

paulhcsun commented Apr 14, 2025

Uh oh!

mergify bot commented Apr 14, 2025

❌ Mergify doesn't have permission to update

Uh oh!

mergify bot commented Apr 14, 2025

Uh oh!

mergify bot commented Apr 14, 2025

Uh oh!

mergify bot commented Apr 14, 2025

Uh oh!

paulhcsun left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

☑️ Nothing to do

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

tttol commented Apr 15, 2025

Uh oh!

paulhcsun commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

❌ Mergify doesn't have permission to update

Uh oh!

paulhcsun commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

aws-cdk-automation commented Apr 15, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

tttol commented Apr 13, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Apr 13, 2025 •

edited

Loading