-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(codebuild): enhance validation for Windows image types #34125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Can someone explain to me what should I do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tsuga for contributing, can grant exemption once comment related to throwing error for unsupported region is addressed, please see our contributing guide if you've any questions about how integration tests work 👍
https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md
|
@shikha372 I've updated the PR. Now, the check will not raise an error but issue a warning. |
Thanks @tsuga will need to fix the current failing build for unit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed tasks:
- aws-cdk-lib:test
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34121
Reason for this change
Windows on-demand environment is supported in a few regions, however the CDK validation raises an error regardless of the region.
Description of changes
Extend the validation logic to include regional constraints.
In addition, reference notes are added to the logics.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
jest test is extended.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license