Skip to content

Conversation

@tsuga
Copy link

@tsuga tsuga commented Apr 12, 2025

Issue # (if applicable)

Closes #34121

Reason for this change

Windows on-demand environment is supported in a few regions, however the CDK validation raises an error regardless of the region.

Description of changes

Extend the validation logic to include regional constraints.
In addition, reference notes are added to the logics.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

jest test is extended.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 12, 2025 18:16
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Apr 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@tsuga
Copy link
Author

tsuga commented Apr 13, 2025

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Can someone explain to me what should I do?
I am new to this codebase and don't get it.

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 13, 2025
@shikha372 shikha372 self-assigned this Apr 15, 2025
@github-actions github-actions bot added p2 and removed p1 labels Apr 23, 2025
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tsuga for contributing, can grant exemption once comment related to throwing error for unsupported region is addressed, please see our contributing guide if you've any questions about how integration tests work 👍

https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md

@shikha372 shikha372 removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Apr 23, 2025
@tsuga
Copy link
Author

tsuga commented May 4, 2025

@shikha372 I've updated the PR. Now, the check will not raise an error but issue a warning.

@shikha372
Copy link
Contributor

@shikha372 I've updated the PR. Now, the check will not raise an error but issue a warning.

Thanks @tsuga will need to fix the current failing build for unit test

Failed tasks:

- aws-cdk-lib:test

shikha372
shikha372 previously approved these changes May 12, 2025
@shikha372 shikha372 dismissed their stale review May 12, 2025 21:28

build needs to be fixed

Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed tasks:

  • aws-cdk-lib:test

@shikha372 shikha372 added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels May 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 12, 2025 22:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed shikha372’s stale review May 21, 2025 16:10

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c397d8a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-codebuild: missing support for Windows on-demand environment

3 participants