-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(apigateway): dualstack REST API #34114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34114 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should DomainName
also be updated to support ipAddressType
as well?
Co-authored-by: Laurel May <[email protected]>
Co-authored-by: Laurel May <[email protected]>
@laurelmay Thank you for your review!
I can also update the |
I think it can be separate! Doing the integration tests for things that require DNS names can be a bit of a hurdle. Just thought I'd point it out in case you wanted to do it hear. Thanks for your work on this! |
@laurelmay Thank for your review! |
throw new ValidationError('Only one of the RestApi props, endpointTypes or endpointConfiguration, is allowed', this); | ||
} | ||
if (props.endpointConfiguration) { | ||
const endpointConfiguration = props.endpointConfiguration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking comment but would appreciate better readability. Something like
const isPrivateApi = endpointConfiguration.types.includes(EndpointType.PRIVATE);
const isIpv4Only = endpointConfiguration.ipAddressType === IpAddressType.IPV4;
if (isPrivateApi && isIpv4Only) {
throw new ValidationError(
'Private APIs must use a dualstack IP address type (IPv4 + IPv6).',
this
);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've updated my implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and good to go
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Pull request has been modified.
@QuantumNeuralCoder Could you please approve again? |
@QuantumNeuralCoder Could you please confirm again? CI jobs had failed after your approval again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
AWS APIGW (REST API) now supports for configuring endpoint IP address type.
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-ip-address-type.html
Description of changes
IpAddressType
ipAddressType
toEndpointConfiguration
Describe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license