-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(s3tables-alpha): add rosetta support to docs and make package non-private #34108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34108 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of multiple rosetta files, can we able to have in a single default.ts-fixture
file similar to other alpha modules
### Define an S3 Table Bucket | ||
|
||
```ts | ||
```ts fixture=with-table-bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we use default.ts-fixture
we may not required to specify this i believe.
"publishConfig": { | ||
"tag": "latest" | ||
}, | ||
"awslint": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For awslint, can we specify in awslint.json
similar to the approach followed by other alpha modules
Pull request has been modified.
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Description of changes
Add support for rosetta for README and JSDocs examples.
This module was previously set to private, due to which it was not released as an npm module and was not showing up on aws-cdk documentation.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
yarn build+test+extract
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license