Skip to content

Conversation

xuxey
Copy link
Contributor

@xuxey xuxey commented Apr 10, 2025

Reason for this change

  • Add rosetta support for s3tables-alpha documentation.
  • Set @aws-cdk/aws-s3tables-alpha module to non-private.

Description of changes

Add support for rosetta for README and JSDocs examples.

This module was previously set to private, due to which it was not released as an npm module and was not showing up on aws-cdk documentation.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn build+test+extract

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 10, 2025 20:34
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 10, 2025
@xuxey xuxey changed the title chore: set aws-s3tables-alpha module to public chore(aws-s3tables-alpha): set aws-s3tables-alpha module to public Apr 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@xuxey xuxey changed the title chore(aws-s3tables-alpha): set aws-s3tables-alpha module to public chore(s3tables-alpha): set aws-s3tables-alpha module to public Apr 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 10, 2025 20:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (9f65f77).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34108   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xuxey xuxey changed the title chore(s3tables-alpha): set aws-s3tables-alpha module to public chore(s3tables-alpha): add rosetta support to docs and make package non-private Apr 10, 2025
@xuxey xuxey marked this pull request as ready for review April 10, 2025 22:39
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 10, 2025
@godwingrs22 godwingrs22 self-assigned this Apr 10, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of multiple rosetta files, can we able to have in a single default.ts-fixture file similar to other alpha modules

Reference: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-ec2-alpha/rosetta/default.ts-fixture

### Define an S3 Table Bucket

```ts
```ts fixture=with-table-bucket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we use default.ts-fixture we may not required to specify this i believe.

Reference: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-ec2-alpha/README.md

"publishConfig": {
"tag": "latest"
},
"awslint": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For awslint, can we specify in awslint.json similar to the approach followed by other alpha modules

Example: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-ec2-alpha/awslint.json

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 11, 2025
@mergify mergify bot dismissed godwingrs22’s stale review April 11, 2025 17:19

Pull request has been modified.

godwingrs22
godwingrs22 previously approved these changes Apr 11, 2025
@mergify mergify bot dismissed godwingrs22’s stale review April 11, 2025 18:41

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 11, 2025
Copy link
Contributor

mergify bot commented Apr 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9f65f77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit baa4a5c into aws:main Apr 11, 2025
20 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants