Skip to content

chore: retain replica table (under feature flag) #33970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2025
Merged

chore: retain replica table (under feature flag) #33970

merged 4 commits into from
Mar 29, 2025

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Mar 28, 2025

Follow up to this PR to add feature flag #33953

@github-actions github-actions bot added the p2 label Mar 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 28, 2025 23:06
@GavinZZ GavinZZ mentioned this pull request Mar 28, 2025
Merged
1 task
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 28, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (2a8a8a3) to head (a09dbf2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33970   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         120      120           
  Lines        6960     6960           
  Branches     1175     1175           
=======================================
  Hits         5735     5735           
  Misses       1120     1120           
  Partials      105      105
Flag Coverage Δ
suite.unit 82.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GavinZZ GavinZZ marked this pull request as ready for review March 28, 2025 23:16
xazhao
xazhao approved these changes Mar 28, 2025
View reviewed changes
...@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.table-skip-replica-deletion.ts
Comment on lines +27 to +31
const app = new App({
postCliContext: {
'@aws-cdk/aws-dynamodb:retainTableReplica': true,
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the cli context for default value is not needed.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a67c3f5 into main Mar 29, 2025
20 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the yuanhaoz/table-fix-ff branch March 29, 2025 00:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a09dbf2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xazhao xazhao xazhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GavinZZ @aws-cdk-automation @xazhao