feat(ec2): enabling features for ipv6 and dualstack support with corresponding unit tests #33873
Conversation
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This work has been moved to PR #33898, which contains an updated implementation. |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
…esponding unit tests (#33898) Enabling features for ipv6 and dualstack support with corresponding unit tests ### Original PR: [#3873](#33873) ### Issue [#33493](#33493) Closes [#33493](#33493) ### Reason for this change Currently, AWS Services, i.e., Xray, Wafv2, Workmail, have started to release support for IPv6 or Dualstack for their VPC endpoints. We would like to modify our infrastructure to be able to support. these new IP address types. ### Description of changes 1. Passed necessary props to the VPC Endpoint interface 2. Added necessary props that need to be passed to enable all different IP address types 3. Abstracted address types as enum to abide by L1, L2 constructs 4. Added necessary unit tests to cover all cases 5. Added necessary changes to integ tests Added more detailed descriptions and guidlines for usage in the aws-ec2 README.md as well as very detailed comments above each code change. ### Description of how you validated changes Added unit tests and integ tests to cover all valid and invalid cases. Throws necessary errors according to [documentation](https://docs.aws.amazon.com/vpc/latest/privatelink/create-endpoint-service.html#connect-to-endpoint-service). Detailed descriptions of each case are outlined in comments. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Enabling features for ipv6 and dualstack support with corresponding unit tests
Issue #33493
Closes #33493
Reason for this change
Currently, AWS Services, i.e., Xray, Wafv2, Workmail, have started to release support for IPv6 or Dualstack for their VPC endpoints. We would like to modify our infrastructure to be able to support. these new IP address types.
Description of changes
Added more detailed descriptions and guidlines for usage in the aws-ec2 README.md as well as very detailed comments above each code change.
Description of how you validated changes
Added unit tests and integ tests to cover all valid and invalid cases. Throws necessary errors according to documentation. Detailed descriptions of each case are outlined in comments.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license