Skip to content

Conversation

@IkeNefcy
Copy link
Contributor

@IkeNefcy IkeNefcy commented Mar 21, 2025

Issue

Closes #33866

Reason for this change

#33729 missing readme update for cx-api

Description of changes

added readme

* `@aws-cdk/aws-events:requireEventBusPolicySid`
When this flag is enabled:
- Resource policies will be created with Statement IDs for service principals
- The operation will succeed as expected
When this flag is disabled:
- A warning will be emitted
- The grant operation will be dropped
- No permissions will be added
_cdk.json_
```json
{
"context": {
"@aws-cdk/aws-events:requireEventBusPolicySid": true
}
}
```

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Mar 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 21, 2025 18:21
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@IkeNefcy
Copy link
Contributor Author

Exemption Request for both, it's saying this because I added the comment wall back in
//////////////////////////////////////////////////////////////////////

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 21, 2025
@IkeNefcy
Copy link
Contributor Author

although it didn't say it for this PR lol strange #33796

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (8e4374f) to head (2de5569).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33867   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6938     6938           
  Branches     1170     1170           
=======================================
  Hits         5716     5716           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 21, 2025
@IkeNefcy
Copy link
Contributor Author

@GavinZZ I think it needs the exemption tags to move on

@GavinZZ GavinZZ added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 21, 2025 21:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2de5569
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6761f56 into aws:main Mar 21, 2025
20 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2025
@IkeNefcy IkeNefcy deleted the restoringOrderPart2 branch October 14, 2025 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cx-api: Missing readme from ff

3 participants