fix(core): platform is ignored during asset bundling

[ejschaefer]

Issue # (if applicable)

Closes #30239

Reason for this change

The BundlingOptions platform property is not being used in AssetBundlingBindMount or AssetBundlingVolumeCopy and is not passed as a command line option to Docker.

Fix makes the platform property work as described in BundlingOptions documentation: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.BundlingOptions.html#platform.

Description of changes

added platform: this.options.platform to AssetBundlingBindMount.run and AssetBundlingVolumeCopy.run in packages/aws-cdk-lib/core/lib/asset-staging.ts

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added platform property to unit and integration tests

• packages/aws-cdk-lib/core/test/private/asset-staging.test.ts
• packages/@aws-cdk-testing/framework-integ/test/aws-s3-assets/test/integ.assets.bundling.docker-opts.ts

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[ejschaefer]

Exemption Request - I updated existing integration tests to include the platform option but there are no changes to generated templates

[iliapolo]

Added exemption from integration test because indeed this change does not cause a snapshot diff. Modifications to existing tests are sufficient.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[iliapolo]

@ejschaefer I'm happy to merge this but can you please explain how this change fixes #33522? Seems unrelated because platform was ignored during bundling, but said issue speaks about a docker image asset that is pushed to ECR.

[github-actions]

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[ejschaefer]

commenting to keep PR open

@iliapolo - I believe the DockerImageCode.fromImageAsset code path uses the same AssetBundling path to build locally before pushing to ECR. I will confirm shorly

[tech-meppem]

Also came across this, where platform is not passed to the cli command.
Also, it seems that buildArgs also aren't passed to the cli, as setting {"--platform": "linux/arm64"} as the buildArgs in bundling options doesn't pass through either.
I'm using @aws-cdk/aws-lambda-go-alpha for context.

[ejschaefer]

@ejschaefer I'm happy to merge this but can you please explain how this change fixes #33522? Seems unrelated because platform was ignored during bundling, but said issue speaks about a docker image asset that is pushed to ECR.

@iliapolo - finally had a free moment to recheck #33522. You're correct, that issue is unrelated to this change. I updated the PR description to remove the reference.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 4c8753c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.