Skip to content

Conversation

gracelu0
Copy link
Contributor

@gracelu0 gracelu0 commented Mar 19, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Group was deprecated in favour of ScheduleGroup in #33678 - we want to remove the Group class altogether to keep the codebase clean and prevent additional breaking changes after graduation.

Description of changes

  • delete Group file and unit test file
  • replace any remaining usages of Group and group with ScheduleGroup and scheduleGroup

Describe any new or updated permissions being added

n/a

Description of how you validated changes

updated unit and integration tests

Checklist

BREAKING CHANGE: Group has been removed. Use ScheduleGroup instead. In the Scheduleconstruct, use the scheduleGroup property instead of group to specify the schedule group.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 01:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 19, 2025
@gracelu0 gracelu0 changed the title chore(scheduler-alpha): remove Group fix(scheduler-alpha): remove Group Mar 19, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@gracelu0 gracelu0 added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 19, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 19, 2025 01:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (2623e00) to head (6f9df3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33823   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6f9df3a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@gracelu0
Copy link
Contributor Author

Closing as we will make this change in the stabilized module since the alpha modules will get deleted afterwards anyway.

@gracelu0 gracelu0 closed this Mar 19, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants