Skip to content

Conversation

@Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 17, 2025

Issue # (if applicable)

Related to #33757 and #33758

Reason for this change

The module has the KinesisFirehoseStreamV2 target class for Firehose delivery stream.
But it has following issues:

  • Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class should not be called Kinesis. Also, KinesisFirehoseStream is confusable with Kinesis Data Stream.
  • The constructor receives internally defined IDeliveryStream which is a subset of aws_kinesisfirehose.IDeliveryStream without inheritance. This may cause jsii type compatibility problem.

Description of changes

  • Added a new FirehoseDeliveryStream target class derived from KinesisFirehoseStreamV2 but receives aws_kinesisfirehose.IDeliveryStream instead.
  • Deprecated KinesisFirehoseStreamV2 and internal IDeliveryStream.
  • Added missing unit tests for FirehoseDeliveryStream
  • Updated the integ test to use FirehoseDeliveryStream and assertions.
  • Added an missing README entry refers Amazon Data Firehose.

Describe any new or updated permissions being added

N/A - FirehoseDeliveryStream adds same permissions as KinesisFirehoseStreamV2

Description of how you validated changes

Unit tests and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2025 06:40
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (a67c3f5) to head (286b140).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33798   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         120      120           
  Lines        6960     6960           
  Branches     1175     1175           
=======================================
  Hits         5735     5735           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2025
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
…o `FirehosePutRecord` (#33758)

### Issue # (if applicable)

Related to #33757 and #33798

### Reason for this change

Kinesis Data Firehose is now Amazon Data Firehose.
Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis.

### Description of changes

- Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord`
- Updated related tests and documents.

### Describe any new or updated permissions being added

Nothing changed.

### Description of how you validated changes

Updated tests and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hwum pushed a commit to hwum/aws-cdk that referenced this pull request Mar 18, 2025
…o `FirehosePutRecord` (aws#33758)

### Issue # (if applicable)

Related to aws#33757 and aws#33798

### Reason for this change

Kinesis Data Firehose is now Amazon Data Firehose.
Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis.

### Description of changes

- Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord`
- Updated related tests and documents.

### Describe any new or updated permissions being added

Nothing changed.

### Description of how you validated changes

Updated tests and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
shikha372 pushed a commit to shikha372/aws-cdk that referenced this pull request Apr 4, 2025
…o `FirehosePutRecord` (aws#33758)

### Issue # (if applicable)

Related to aws#33757 and aws#33798

### Reason for this change

Kinesis Data Firehose is now Amazon Data Firehose.
Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis.

### Description of changes

- Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord`
- Updated related tests and documents.

### Describe any new or updated permissions being added

Nothing changed.

### Description of how you validated changes

Updated tests and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@Tietew Tietew changed the title fix(events-targets): rename KinesisFirehoseStreamV2 to FirehoseDeliveryStream feat(events-targets): support Amazon Data Firehose target using Firehose's IDeliveryStream May 14, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e566700
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the file is still a breaking change, as this will break for users who directly import via the filename, e.g:

import { KinesisFirehoseStreamV2 } from 'aws-cdk-lib/aws-events-targets/lib/kinesis-firehose-stream'

We should add in the old filename which just imports and re-exports the contents of the new file firehose.ts, e.g.:

import * as firehose from './firehose.ts'

export default firehose;

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 23, 2025
@Abogical Abogical self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants