-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(events-targets): support Amazon Data Firehose target using Firehose's IDeliveryStream
#33798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33798 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 120 120
Lines 6960 6960
Branches 1175 1175
=======================================
Hits 5735 5735
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…o `FirehosePutRecord` (#33758) ### Issue # (if applicable) Related to #33757 and #33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…o `FirehosePutRecord` (aws#33758) ### Issue # (if applicable) Related to aws#33757 and aws#33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…o `FirehosePutRecord` (aws#33758) ### Issue # (if applicable) Related to aws#33757 and aws#33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
KinesisFirehoseStreamV2 to FirehoseDeliveryStreamIDeliveryStream
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming the file is still a breaking change, as this will break for users who directly import via the filename, e.g:
import { KinesisFirehoseStreamV2 } from 'aws-cdk-lib/aws-events-targets/lib/kinesis-firehose-stream'We should add in the old filename which just imports and re-exports the contents of the new file firehose.ts, e.g.:
import * as firehose from './firehose.ts'
export default firehose;
Issue # (if applicable)
Related to #33757 and #33758
Reason for this change
The module has the
KinesisFirehoseStreamV2target class for Firehose delivery stream.But it has following issues:
IDeliveryStreamwhich is a subset ofaws_kinesisfirehose.IDeliveryStreamwithout inheritance. This may cause jsii type compatibility problem.Description of changes
FirehoseDeliveryStreamtarget class derived fromKinesisFirehoseStreamV2but receivesaws_kinesisfirehose.IDeliveryStreaminstead.KinesisFirehoseStreamV2and internalIDeliveryStream.FirehoseDeliveryStreamFirehoseDeliveryStreamand assertions.Describe any new or updated permissions being added
N/A -
FirehoseDeliveryStreamadds same permissions asKinesisFirehoseStreamV2Description of how you validated changes
Unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license