Skip to content

Conversation

@ymhiroki
Copy link
Contributor

Reason for this change

This feature allows customers to create Service Catalog products of different types, such as CloudFormation templates, Terraform configurations, or external products.

Description of changes

  • Added a new productType property to the CloudFormationProductProps interface
  • Updated the CloudFormationProduct class to support the productType property
  • Added a new test case to verify the ProductType configuration

These changes enable customers to specify the product type when creating a Service Catalog product.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

The changes have been validated through the addition of a new unit test case and the integration test that verifies the `ProductType configuration.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 16, 2025 05:30
@github-actions github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Mar 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@ymhiroki ymhiroki changed the title Yhirokiy/servicecatalog product type feat(servicecatalog): added property productType for servicecatalog Mar 16, 2025
@ymhiroki ymhiroki closed this Mar 16, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fb29ecd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants