Skip to content

Conversation

aditya-shrey
Copy link

Issue

Closes #16335.

Reason for this change

Currently, FirewallRuleGroup allows importing an existing rule group by ID using fromFirewallRuleGroupID() , but there is no built-in way to reference an existing rule group by name. Users need to implement their own lookup logic via the AWS SDK. This change provides a direct method to import a firewall rule group by name, simplifying the process.

Description of changes

  • Added FirewallRuleGroup.fromFirewallRuleGroupName(), which allows users to import a firewall rule group using its name instead of just an ID.
  • The method retrieves the rule group ID from the CDK context.
  • If the provided firewall rule group name is not found in the context, it throws a meaningful error.
  • Created unit tests, ensuring correct ID is returned when a valid name mapping is provided in the context and an error is thrown if firewall rule group name is not found in the context.

Describe any new or updated permissions being added

None

Description of how you validated changes

  • Unit Tests: Added tests in firewall-rule-group.test.ts to validate both successful and failing cases.

Checklist

Acknowledgments

Thanks to @arvchahal for collaboration on this feature!


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Mar 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 15, 2025 07:09
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ Pull requests from `main` branch of a fork cannot be accepted. Please reopen this contribution from another branch on your fork. For more information, see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch.

Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dccd802
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FirewallRuleGroup lookup by name

2 participants