-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(core): remove whitespaces in tree.json #33784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change, but it doesn't solve the issue yet.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should update or rebase your pull request manually. If you want to requeue this pull request, you can post a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33784 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
tree.json can grow too large to be serialized, as detailed in aws#27261. One reason why the file is very large is that the serialization uses indentation level of 2. Removing the whitespace from serialization will return a lot of spaces, and it is a very straightforward change. This is OK to do because the file is not meant to be read by human anyway. This PR implements the solution. Ideally, in the future we should also make it possible to split tree.json into multiple files or use the solution in bmoffatt@91edfec, to make it scalable. At that stage, it's also possible to turn indentation space back to 2 (perhaps to aid debugging). For now, however, this issue is blocking the deployment in our team, and we really need this fix to continue. Relates to aws#27261
Thanks, @rix0rrr! I rebased as mergify suggested, and also reworded "fixes ..." in the commit message to "relates to ..." in the latest revision. Let me know if there's anything else I should do! |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Relates to #27261
Reason for this change
Makes it possible to synthesize our CDK application, which errors due to tree.json hitting 512mb, which is node's max string size.
Description of changes
tree.json can grow too large to be serialized, as detailed in #27261. One reason why the file is very large is that the serialization uses indentation space of 2. Removing the whitespace from serialization will return a lot of spaces, and it is a very straightforward change. This is OK to do because the file is not meant to be read by human anyway. This PR implements the solution.
Ideally, in the future we should also make it possible to split tree.json into multiple files or use the solution in bmoffatt@91edfec, to make it scalable. At that stage, it's also possible to turn indentation space back to 2 (perhaps to aid debugging).
For now, however, this issue is blocking the deployment in our team, and we really need this fix to continue.
Describe any new or updated permissions being added
No permission involved.
Description of how you validated changes
Does not affect any functionality.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license