Skip to content

Conversation

sorawee
Copy link
Contributor

@sorawee sorawee commented Mar 14, 2025

Issue # (if applicable)

Relates to #27261

Reason for this change

Makes it possible to synthesize our CDK application, which errors due to tree.json hitting 512mb, which is node's max string size.

Description of changes

tree.json can grow too large to be serialized, as detailed in #27261. One reason why the file is very large is that the serialization uses indentation space of 2. Removing the whitespace from serialization will return a lot of spaces, and it is a very straightforward change. This is OK to do because the file is not meant to be read by human anyway. This PR implements the solution.

Ideally, in the future we should also make it possible to split tree.json into multiple files or use the solution in bmoffatt@91edfec, to make it scalable. At that stage, it's also possible to turn indentation space back to 2 (perhaps to aid debugging).

For now, however, this issue is blocking the deployment in our team, and we really need this fix to continue.

Describe any new or updated permissions being added

No permission involved.

Description of how you validated changes

Does not affect any functionality.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@sorawee sorawee requested a review from a team as a code owner March 14, 2025 18:07
@github-actions github-actions bot added bug This issue is a bug. p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 14, 2025 18:08
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 17, 2025
rix0rrr
rix0rrr previously approved these changes Mar 17, 2025
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change, but it doesn't solve the issue yet.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 17, 2025 08:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Mar 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Mar 17, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (ab6ba09) to head (d4e9fe5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33784   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify bot dismissed rix0rrr’s stale review March 17, 2025 14:21

Pull request has been modified.

tree.json can grow too large to be serialized, as detailed in aws#27261.
One reason why the file is very large is that the serialization uses
indentation level of 2. Removing the whitespace from serialization
will return a lot of spaces, and it is a very straightforward change.
This is OK to do because the file is not meant to be read by human
anyway. This PR implements the solution.

Ideally, in the future we should also make it possible to split
tree.json into multiple files or use the solution in
bmoffatt@91edfec,
to make it scalable. At that stage, it's also possible to turn
indentation space back to 2 (perhaps to aid debugging).

For now, however, this issue is blocking the deployment in our team,
and we really need this fix to continue.

Relates to aws#27261
@sorawee
Copy link
Contributor Author

sorawee commented Mar 17, 2025

Thanks, @rix0rrr! I rebased as mergify suggested, and also reworded "fixes ..." in the commit message to "relates to ..." in the latest revision. Let me know if there's anything else I should do!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 17, 2025
Copy link
Contributor

mergify bot commented Mar 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 27f80ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 73b9138 into aws:main Mar 17, 2025
10 checks passed
Copy link
Contributor

mergify bot commented Mar 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants