feat(aws-events-target): Enable adding role for sns target to support cross account targets #33782
Conversation
github-actions
bot
added
the
beginning-contributor
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'events-target' instead of 'aws-events-target'.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".
❌ Pull requests from `main` branch of a fork cannot be accepted. Please reopen this contribution from another branch on your fork. For more information, see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
Comments on closed issues and PRs are hard for our team to see. |
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 participants
Issue
In Jan 2025 AWS announced support cross-account targets for Amazon EventBridge Event Buses. For this to work source event bus rules must have an IAM role that allows them to send events to specific targets.
Currently there is no way to add a role to an SNS target which means that one is unable to add an SNS target from a different account. This pr is to enable adding role when adding an SNS target which follows a similar convention to other targets like Codebuild that allows adding a role
Reason for this change
Without this change unable to add a cross account SNS target for Amazon EventBridge Event Buses using the CDK L2 construct
Description of changes
Updated the SNS target to allow one to include a role.
This follows similar approach to other targets such as Codebuild that allows one to include a role (https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-events-targets/lib/codebuild.ts#L46)
Description of how you validated changes
Updated Unit and Integration Tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license