-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(kinesisfirehose): ap-southeast-7 #33777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33777 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
'ap-southeast-3': '108.136.221.64', | ||
'ap-southeast-4': '16.50.161.128', | ||
'ap-southeast-5': '43.216.58.0', | ||
'ap-southeast-7': '43.208.112.96', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link in the PR description which confirm the IP set in this table?
The only reference I could find was: https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look. The link is documented in the code itself
aws-cdk/packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts
Lines 1145 to 1146 in 3d948c4
// https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-rs-vpc | |
export const FIREHOSE_CIDR_BLOCKS: { [region: string]: string } = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I should have expanded the git diff in the "Files changed" view.
'ap-southeast-3': '108.136.221.64', | ||
'ap-southeast-4': '16.50.161.128', | ||
'ap-southeast-5': '43.216.58.0', | ||
'ap-southeast-7': '43.208.112.96', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I should have expanded the git diff in the "Files changed" view.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33730
Description of changes
firehose support
ap-southeast-7
Description of how you validated changes
Integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license