feat(lambda): support s3 OFD for Kinesis/DynamoDB

[roger-zhangg]

Issue # (if applicable)

Closes #.

Reason for this change

Kinesis and DynamoDB has supported S3 as onFailureDestination.

Description of changes

The supportS3OnFailureDestination for kinesis and DynamoDB has changed to true
Tests are updated to reflect this change.

Describe any new or updated permissions being added

No permission change

Description of how you validated changes

Test are run

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[roger-zhangg]

Exemption Request: We have reviewed the Readme file change for this feautre. It's still valid so we don't need a change in Readme file

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (6aca154) to head (9d45f08).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33739   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         120      120           
  Lines        6933     6933           
  Branches     1169     1169           
=======================================
  Hits         5711     5711           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.37% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[samson-keung]

@roger-zhangg We should have integ tests to ensure the CDK generated template will be deployable and ideally assert that the infrastructure behaves as expected in terms of the S3 onFailureDestination config (For example, asserting that failures are indeed flowing to S3).

A related existing test can be found here but it does not have assertions unfortunately.

[samson-keung]

@roger-zhangg I see some READMEs are outdated as they only mentioned SNS or SQS as possible onFailure destination:

https://github.com/search?q=repo%3Aaws%2Faws-cdk%20%22An%20Amazon%20SQS%20queue%20or%20Amazon%20SNS%20topic%20destination%20for%20discarded%20records.%22&type=code

https://github.com/search?q=repo%3Aaws%2Faws-cdk+%22the+record+will+be+sent+to+SQS+queue+or+SNS+topic%22&type=code

I am okay with updating the docs in separate PR though if you prefer.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[samson-keung]

LGTM.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[godwingrs22]

nit: small typo on the file name.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 9d45f08
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.