Skip to content

Conversation

@eladb
Copy link
Contributor

@eladb eladb commented Jul 22, 2019

add a few more tests to cover behaviors of substacks (stacks that are
defined within the scope of another stack) to cover:

  • Same-environment cross stack references
  • Stack.of() finds the right stack
  • PhysicalName.GENERATE_IF_NEEDED is triggered

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

add a few more tests to cover behaviors of substacks (stacks that are
defined within the scope of another stack) to cover:

* Same-environment cross stack references
* Stack.of() finds the right stack
* PhysicalName.GENERATE_IF_NEEDED is triggered
@skinny85 skinny85 force-pushed the benisrae/substack-tests branch from d2199fd to 2e35104 Compare July 23, 2019 23:26
@skinny85
Copy link
Contributor

Fixed the out of order imports that were making the build fail.

@mergify mergify bot merged commit 863f1ff into master Aug 7, 2019
@RomainMuller RomainMuller deleted the benisrae/substack-tests branch August 10, 2019 00:38
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants