fix(lambda): deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy #33689

QuantumNeuralCoder · 2025-03-04T22:59:19Z

Issue # (if applicable)

Closes #.
33688

Reason for this change

Described in the #33688

Description of changes

Set default value of feature flag to false.
Updated description to indicate deprecated feature flag.
Update description to describe the race condition issue which led to this decision.

N/A

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A

Checklist

[ x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ity errors

…RolePolicy

aws-cdk-automation

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

codecov · 2025-03-04T23:24:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (c0f8d29) to head (8f34db0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33689   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112

Flag	Coverage Δ
suite.unit	`83.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`83.98% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GavinZZ · 2025-03-04T23:24:47Z

packages/aws-cdk-lib/cx-api/README.md

+However in the current implementation, we have removed a dependency of the lambda function on the policy. In addition to this, a Role will be attached to the Policy instead of an inline policy being attached to the role. 
+This will create a data race condition in the CloudFormation template because the creation of the Lambda function no longer waits for the policy to be created. 
+We recommend to unset the feature flag if already set which will restore the original behavior. 


I think we should mention if people are okay with the fact that lambda may be created before policy, and they're experiencing circular dependency issue, they can consider setting it to true.

unrelated codecov issue resolved today

QuantumNeuralCoder · 2025-03-19T23:24:56Z

@mergify requeue

mergify · 2025-03-19T23:25:00Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-03-19T23:25:00Z

requeue

❌ This pull request head commit has not been previously disembarked from queue.

aws-cdk-automation

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

mergify · 2025-03-19T23:26:52Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #33689 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

#changes-requested-reviews-by=0
any of: [🔀 queue conditions]
- all of: [📌 queue conditions of queue default-squash]
  - #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

This is a remnant of the interim issue with codecov which prevents this branch from getting merged.

mergify · 2025-04-01T22:36:01Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation

(This review is outdated)

aws-cdk-automation

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

mergify · 2025-04-01T22:38:13Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #33689 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

#changes-requested-reviews-by=0
any of: [🔀 queue conditions]
- all of: [📌 queue conditions of queue default-squash]
  - #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Dismissing outdated PRLinter review.

mergify · 2025-04-01T22:40:09Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-04-01T23:46:03Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 8f34db0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-01T23:46:24Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-01T23:46:28Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #33689 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 1 review requesting changes and 2 approving reviews by reviewers with write access.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

QuantumNeuralCoder · 2025-04-01T23:48:17Z

Exemption request. The integ test files have been merged as a part of other PRs.

mergify · 2025-04-01T23:50:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-01T23:59:49Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

QuantumNeuralCoder and others added 17 commits February 6, 2025 13:29

Update .mergify.yml. Add me, remove Kailey and Michelle

6ca8753

Update .mergify.yml Removing Jacob, Kirti, Colin, Calvin.

47187a0

Merge branch 'aws:main' into main

8a3fd60

Pinning minimatch and @types/glob versions to get rid of incompatibil…

ae36a25

…ity errors

Merge branch 'aws:main' into main

cb336ae

Update codecov.yml

70e0a20

Merge branch 'aws:main' into main

f63e2a7

Merge branch 'aws:main' into main

5b356c0

Merge branch 'aws:main' into main

9cea97f

Merge branch 'aws:main' into main

679f8b1

Merge branch 'aws:main' into main

1851e8b

Merge branch 'aws:main' into main

47333b2

Merge branch 'aws:main' into main

8e73063

Merge branch 'aws:main' into main

34365a1

Merge branch 'aws:main' into main

6c01b62

issue-33688 Merge remote-tracking branch 'upstream/main'

51a0d48

deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddTo…

4c04550

…RolePolicy

QuantumNeuralCoder requested a review from GavinZZ March 4, 2025 22:59

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 4, 2025

aws-cdk-automation requested a review from a team March 4, 2025 22:59

aws-cdk-automation previously requested changes Mar 4, 2025

View reviewed changes

QuantumNeuralCoder added the pr/do-not-merge This PR should not be merged at this time. label Mar 4, 2025

Indranil Dey added 2 commits March 4, 2025 15:07

Removed unrelated files

58e531b

chore: revert unintended changes to files

c7ea0b6

QuantumNeuralCoder removed the pr/do-not-merge This PR should not be merged at this time. label Mar 4, 2025

GavinZZ reviewed Mar 4, 2025

View reviewed changes

xazhao mentioned this pull request Mar 5, 2025

chore: integration test failed because of a new feature flag set to true cdklabs/awscdk-asset-node-proxy-agent#666

Closed

fix: minor updates to the description

e5c0bc5

QuantumNeuralCoder requested a review from aws-cdk-automation March 19, 2025 20:56

Merge branch 'main' into issue-33688

25b0d8b

QuantumNeuralCoder requested a review from 5d March 19, 2025 20:57

5d approved these changes Mar 19, 2025

View reviewed changes

aws-cdk-automation previously requested changes Mar 19, 2025

View reviewed changes

github-actions bot mentioned this pull request Apr 1, 2025

Monthly PR metrics report #33994

Closed

Merge branch 'main' into issue-33688

72d6d66

aws-cdk-automation previously requested changes Apr 1, 2025

View reviewed changes

aws-cdk-automation requested changes Apr 1, 2025

View reviewed changes

Merge branch 'main' into issue-33688

8f34db0

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 1, 2025

QuantumNeuralCoder closed this Apr 1, 2025

github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025

QuantumNeuralCoder deleted the issue-33688 branch May 14, 2025 21:19

Uh oh!

fix(lambda): deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy #33689

fix(lambda): deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy #33689

Uh oh!

Conversation

QuantumNeuralCoder commented Mar 4, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GavinZZ Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

QuantumNeuralCoder Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

QuantumNeuralCoder commented Mar 19, 2025

Uh oh!

mergify bot commented Mar 19, 2025

Uh oh!

mergify bot commented Mar 19, 2025

❌ This pull request head commit has not been previously disembarked from queue.

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 19, 2025

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

aws-cdk-automation commented Apr 1, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

QuantumNeuralCoder commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Mar 4, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading