Skip to content

fix(stepfunctions-tasks): jobQueueArn support JsonPath or JSONata #33670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025
Merged

fix(stepfunctions-tasks): jobQueueArn support JsonPath or JSONata #33670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db1fec6
fix(stepfunctions-tasks): IAM policy use wildcard for JsonPath or JSO…
Mar 2, 2025
f8fc676
Merge branch 'main' into batch-submit-job-iam
phuhung273 Mar 12, 2025
922dfa3
integ
Mar 12, 2025
7e9d9be
Merge branch 'main' into batch-submit-job-iam
scorbiere Mar 18, 2025
5b056a2
Merge branch 'main' into batch-submit-job-iam
scorbiere Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...testing/framework-integ/test/aws-stepfunctions-tasks/test/batch/batchjob-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM public.ecr.aws/lambda/python:3.6
FROM python:3.13-alpine
Copy link
Contributor

@scorbiere scorbiere Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the motivation for this change?

Copy link
Contributor Author

@phuhung273 phuhung273 Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure. The context is:

  • Back in the day, Lambda image behaviour was like executing a job: run and exit
  • Now, all Lambda image act like a backend server: keep running forever

When I tried the old Dockerfile, StateMachine execution never escape RUNNING state as ECS serve the image as a server.

So I decided to use the plain python image.

One weird thing is although there is a test using the changed Dockerfile, no snapshot change was detected. So I only ran my new test file.

Copy link
Contributor

@scorbiere scorbiere Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One weird thing is although there is a test using the changed Dockerfile, no snapshot change was detected. So I only ran my new test file.

After checking the implementation of DockerImageAsset I don't see any logic which use the docker file's content to compute asset's hash.

EXPOSE 8000
WORKDIR /src
ADD . /src
CMD python3 index.py
CMD python index.py
Loading