feat(ecr): lookup existing repository

[badmintoncryer]

Issue # (if applicable)

Closes #8461.

Reason for this change

ecr.Repository construct does not support lookup method.

Description of changes

• Add fromLookup method

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (4e958d4) to head (ce93af4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33662   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6955     6955           
  Branches     1173     1173           
=======================================
  Hits         5730     5730           
  Misses       1120     1120           
  Partials      105      105           

Flag	Coverage Δ
suite.unit	82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.38% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[moelasmar]

minor comment: can you add the region to the error message as well.

[moelasmar]

Also, I believe the ContextProvider.getValue call will return the dummy value in case if it could not find the repo. So lookupRepoName will always has a value.

[badmintoncryer]

You are absolutely right. I have removed this validation.

[badmintoncryer]

I noticed that because Arn.split(repository.Arn, ArnFormat.SLASH_RESOURCE_NAME).resourceName returns string | undefined, it causes a TypeScript error at this.fromRepositoryName(scope, id, lookupRepoName) (since fromRepositoryName cannot accept an optional repository name).

How should we resolve this? I'm considering some approaches such as using a non-null assertion (resourceName!) or adding validation for undefined names.

[badmintoncryer]

@moelasmer Could you please confirm this?

[mrgrain]

Actually you could just use fromRepositoryArn or copy the line that extracts the name from it or use Arn.extractResourceName

https://github.com/aws/aws-cdk/blob/3880a8e561c0e1189e18255af875026280f6a287/packages/aws-cdk-lib/aws-ecr/lib/repository.ts#L713C4-L713C72

[moelasmar]

Thanks @badmintoncryer .. I left some comments

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[badmintoncryer]

@mrgrain Thank you for your review!

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ce93af4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.