Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticloadbalancingv2): support target group health attributes #33351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phuhung273
Copy link
Contributor

feat(elasticloadbalancingv2): support target group health attributes

Issue # (if applicable)

Closes #31821

Reason for this change

elasticloadbalancingv2 support target group health attributes

Description of changes

TargetGroup support 4 heatlh attributes:

  • target_group_health.unhealthy_state_routing.minimum_healthy_targets.percentage
  • target_group_health.dns_failover.minimum_healthy_targets.percentage
  • target_group_health.unhealthy_state_routing.minimum_healthy_targets.count
  • target_group_health.dns_failover.minimum_healthy_targets.count

Cleanup setup duplication in unit test.

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat(elasticloadbalancingv2): support target group health attributes
@aws-cdk-automation aws-cdk-automation requested a review from a team February 8, 2025 15:54
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (fbcb732) to head (1801d8a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33351   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11534    11534           
  Misses       2434     2434           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.73% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1801d8a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticloadbalancingv2: support target group health attributes
2 participants