Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yarn-upgrade): pins versions of @types/glob and minimatch to fix PR-33299 #33329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuantumNeuralCoder
Copy link
Contributor

Issue # (if applicable)

Na
Closes #.
PR-33299

Reason for this change

Pinned versions of @types/glob and minimatch to fix a dependency issue. Tested using workflow step collect (run)in my fork which passes the build now.

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 7, 2025 00:39
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 7, 2025
@QuantumNeuralCoder QuantumNeuralCoder changed the title Pins versions of @types/glob and minimatch to fix PR-33299 chore(yarn-upgrade): pins versions of @types/glob and minimatch to fix PR-33299 Feb 7, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 21d0684
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (ec4b91b) to head (21d0684).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33329   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 7, 2025

If these are transitive dependencies I’m not sure this will help…?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants