-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront): vpc origins #33318
base: main
Are you sure you want to change the base?
Conversation
httpsPort: props.httpsPort, | ||
name: props.vpcOriginName ?? Names.uniqueResourceName(this, {}), | ||
originProtocolPolicy: props.protocolPolicy, | ||
originSslProtocols: props.originSslProtocols ?? [OriginSslPolicy.TLS_V1_2], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of originSslProtocols
is ['SSLv3', 'TLSv1']
.
This explicit default ['TLSv1.2']
is same as the AWS management console.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33318 +/- ##
==========================================
+ Coverage 80.83% 80.92% +0.08%
==========================================
Files 236 236
Lines 14251 14253 +2
Branches 2490 2490
==========================================
+ Hits 11520 11534 +14
+ Misses 2446 2434 -12
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Dismissing outdated PRLinter review.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32396.
Reason for this change
VPC origins has been added to CloudFront and now CloudFormation supports it.
For details, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-vpc-origins.html
Description of changes
Added an L2 construct
cloudfront.VpcOrigin
forAWS::CloudFront::VpcOrigin
.It will be created implicitly by origin class described below.
You can create it explicitly to share VPC origins between distributions.
Added an origin class
cloudfront_origins.VpcOrigin
for distribution configuration.It can be configured with an Application Load Balancer, a Network Load Balancer, an EC2 instance, or a
cloudfront.VpcOrigin
construct.Describe any new or updated permissions being added
No permissions are added automatically.
See README how to allow connections from VPC origins.
Description of how you validated changes
Unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license