Skip to content

chore(toolkit): fix various inconsistenncies with hotswap settings #33240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2025
Merged

chore(toolkit): fix various inconsistenncies with hotswap settings #33240

merged 2 commits into from
Jan 30, 2025

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 30, 2025

Description of changes

  • Make ExtendedDeployOptions properly private
  • Don't print warnings if hotswap mode is not provided
  • default watch action to HOTSWAP_ONLY
  • fix watch user-agent

Describe any new or updated permissions being added

n/a

Description of how you validated changes

updated tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain
chore(toolkit): fix various inconsistenncies with hotswap settings
59f7ea8 
- Make ExtendedDeployOptions properly private
- Don't print warnings if hotswap mode is not defined
- default watch to HOTSWAP_ONLY
- fix watch user-agent
@github-actions github-actions bot added the p2 label Jan 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 30, 2025 16:00
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (62b3b60) to head (159d387).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33240   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         232      232           
  Lines       14135    14135           
  Branches     2460     2460           
=======================================
  Hits        11428    11428           
  Misses       2427     2427           
  Partials      280      280
Flag Coverage Δ
suite.unit 80.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.64% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 30, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 159d387
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 64338f2 into main Jan 30, 2025
20 checks passed
@mergify mergify bot deleted the mrgrain/fix/hotswap-settings branch January 30, 2025 17:49
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrgrain @aws-cdk-automation @kaizencc