chore(cli-integ): make it possible to run on GitHub Actions #33175
Conversation
Migrate some changes back from the new testing repo. These changes are necessary to make the tests run on GitHub Actions. If we keep them here, in the future we can do a `cp -R` on the test directory. If not, we'll have to do manual sorting on every copy over, which is annoying and easy to make mistakes in.
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
changed the title
| } | ||
|
|
||
| export class AwsClients { | ||
| public static async default(output: NodeJS.WritableStream) { |
There was a problem hiding this comment.
Why did you add this back in? No tests are using it anymore.
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33175 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 232 232
Lines 14111 14111
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2431 2431
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…cdk into huijbers/integtest-changes-back
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
rix0rrr
added
pr-linter/cli-integ-tested
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
4 participants
Migrate some changes back from the new testing repo. These changes are necessary to make the tests run on GitHub Actions.
If we keep them here, in the future we can do a
cp -Ron the test directory. If not, we'll have to do manual sorting on every copy over, which is annoying and easy to make mistakes in.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license