Skip to content

chore: npm-check-updates && yarn upgrade #33168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

chore: npm-check-updates && yarn upgrade #33168

wants to merge 3 commits into from

Conversation

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jan 26, 2025

Ran npm-check-updates and yarn upgrade to keep the yarn.lock file up-to-date.

@aws-cdk-automation aws-cdk-automation requested a review from a team as a code owner January 26, 2025 00:42
@aws-cdk-automation aws-cdk-automation added contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. labels Jan 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 26, 2025 00:42
@github-actions github-actions bot added the p2 label Jan 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 26, 2025 00:42
@moelasmar
Copy link
Contributor

moelasmar commented Jan 26, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025

update

✅ Branch has been successfully updated

@mergify mergify bot temporarily deployed to test-pipeline January 26, 2025 00:46 Inactive
@aws-cdk-automation
Copy link
Collaborator Author

aws-cdk-automation commented Jan 26, 2025

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@QuantumNeuralCoder QuantumNeuralCoder self-assigned this Jan 28, 2025
@aws-cdk-automation @github-actions
chore: npm-check-updates && yarn upgrade
a84f4b8 
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
@QuantumNeuralCoder QuantumNeuralCoder mentioned this pull request Jan 30, 2025
Closed
@aws-cdk-automation
Copy link
Collaborator Author

aws-cdk-automation commented Jan 30, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b4b4bf4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@QuantumNeuralCoder
Copy link
Contributor

QuantumNeuralCoder commented Jan 31, 2025

Closing this PR since we need to update the dependencies as follows

  1. Remove @types/glob
  2. Add glob:latest
  3. Refactor cdk-copy to use async version of glob api.

These changes need Node20 which is under discussion. Until that time we cannot upgrade.
Refer conversation on #33231 for more details

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@QuantumNeuralCoder QuantumNeuralCoder

Labels

auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aws-cdk-automation @moelasmar @QuantumNeuralCoder