Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 23, 2025

This is necessary because it requires code changes in order to be compatible with the new version, which we need for the monorepo.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is necessary because it requires code changes in order to be
compatible with the new version, which we need for the monorepo.
@rix0rrr rix0rrr requested a review from a team as a code owner January 23, 2025 08:45
@github-actions github-actions bot added the p2 label Jan 23, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 08:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (ecbe1bf) to head (acff216).

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33088      +/-   ##
==========================================
- Coverage   80.79%   80.78%   -0.01%     
==========================================
  Files         232      232              
  Lines       14110    14111       +1     
  Branches     2453     2453              
==========================================
  Hits        11400    11400              
- Misses       2430     2431       +1     
  Partials      280      280              
Flag Coverage Δ
suite.unit 80.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.51% <0.00%> (-0.02%) ⬇️
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@rix0rrr rix0rrr added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 24, 2025
"archiver": "^5.3.2",
"camelcase": "^6.3.0",
"cdk-assets": "3.0.0-rc.124",
"cdk-assets": "^3.0.0-rc.127",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caret has no effect with pre-release versions.

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@rix0rrr rix0rrr added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 26, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 26, 2025 20:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: acff216
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr merged commit db332ef into main Jan 27, 2025
13 of 18 checks passed
@rix0rrr rix0rrr deleted the huijbers/bump-cdk-assts branch January 27, 2025 08:23
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-codecov The PR linter will not require codecov checks to pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants