Skip to content

Conversation

@Dringho
Copy link
Contributor

@Dringho Dringho commented Jan 20, 2025

Issue # (if applicable)

#33017

Closes #33017.

Reason for this change

Typo

Description of changes

Fixed Typo

Describe any new or updated permissions being added

NA

Description of how you validated changes

No

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 20, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 20, 2025 13:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Dringho Dringho changed the title Typo AWS Payment Cryptography VPC Endpoint fix(vpc): Typo VPC Endpoint Payment Cryptography Jan 20, 2025
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Dringho! thanks for noticing this! unfortunately we cannot just update the property name because that would be a breaking change....

instead we have to leave this one as is, and deprecate it. we can add a new static property with the correct name. does that make sense?

@aaythapa
Copy link
Contributor

aaythapa commented Feb 5, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (fd05c10) to head (58a7d92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33018   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@aaythapa aaythapa changed the title fix(vpc): Typo VPC Endpoint Payment Cryptography fix(vpc): typo VPC Endpoint Payment Cryptography Feb 5, 2025
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Feb 5, 2025
@aaythapa aaythapa added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed bug This issue is a bug. effort/small Small work item – less than a day of effort labels Feb 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 5, 2025 19:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aaythapa
aaythapa previously approved these changes Feb 5, 2025
@aaythapa aaythapa dismissed kaizencc’s stale review February 5, 2025 19:50

implemented Kaizen's requested changed, small change so don't need 2 reviews

@aaythapa
Copy link
Contributor

aaythapa commented Feb 5, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

@Mergifyio dequeue

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #33018 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

dequeue

✅ The pull request has been removed from the queue default-squash

@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

@Mergifyio dequeue

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

dequeue

☑️ The pull request is not queued

@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

Dequeued again because build is failing.

@aaythapa
Copy link
Contributor

aaythapa commented Feb 6, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aaythapa
Copy link
Contributor

aaythapa commented Feb 7, 2025

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #33018 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed aaythapa’s stale review February 7, 2025 06:51

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3e2f587
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 51e671f into aws:main Feb 7, 2025
14 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ec2: InterfaceEndpointTypo PAYMENT_CRYTOGRAPHY_DATAPLANE

6 participants