Skip to content

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jan 15, 2025

This PR pulls out changes to packages/aws-cdk and packages/@aws-cdk/cli-lib-alpha from #32919


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner January 15, 2025 17:45
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 17:45
@github-actions github-actions bot added the p2 label Jan 15, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 15, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 15, 2025
Copy link
Contributor Author

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is momo's code. i have reviewed and approve pending integ tests.

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 84.84848% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (31477af) to head (f8cf569).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32953      +/-   ##
==========================================
+ Coverage   81.40%   81.48%   +0.07%     
==========================================
  Files         223      226       +3     
  Lines       13727    13768      +41     
  Branches     2411     2416       +5     
==========================================
+ Hits        11175    11219      +44     
+ Misses       2274     2271       -3     
  Partials      278      278              
Flag Coverage Δ
suite.unit 81.48% <84.84%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.89% <84.84%> (+0.15%) ⬆️
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jan 15, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jan 15, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

update

✅ Branch has been successfully updated

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2025 20:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f8cf569
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mrgrain mrgrain merged commit 3a711b0 into main Jan 15, 2025
15 of 17 checks passed
@mrgrain mrgrain deleted the conroy/cli4 branch January 15, 2025 21:55
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants