Skip to content

fix(lambda-event-sources): SelfManagedKafkaEventSource cannot be used in NPM symlinked workspaces #32937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2025
Merged

fix(lambda-event-sources): SelfManagedKafkaEventSource cannot be used in NPM symlinked workspaces #32937

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df89912
fix: replace instanceof check by Construct.isConstruct call
Jan 15, 2025
9d2efa5
Merge branch 'main' into replace-instanceof
mergify[bot] Jan 15, 2025
1d8a605
Merge branch 'main' into replace-instanceof
Jan 20, 2025
8948413
Merge branch 'main' into replace-instanceof
kaizencc Feb 6, 2025
1d9aebe
Merge branch 'main' into replace-instanceof
mergify[bot] Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-lambda-event-sources/lib/kafka.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export class SelfManagedKafkaEventSource extends StreamEventSource {
}

public bind(target: lambda.IFunction) {
if (!(target instanceof Construct)) { throw new Error('Function is not a construct. Unexpected error.'); }
if (!(Construct.isConstruct(target))) { throw new Error('Function is not a construct. Unexpected error.'); }
target.addEventSourceMapping(
this.mappingId(target),
this.enrichMappingOptions({
Expand Down