Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 13, 2025

For the Aspect property tests, make some changes to make it easier to see what's going on:

  • Instead of just a visit log, keep a log of all actions: adding constructs, adding aspects, and visiting are now all part of the same time sequence with time steps so it's easier to reason about.
  • Clearly mark timed steps with t=0, t=1, etc.
  • Add the option to configure the number of runs using FAST_CHECK_NUM_RUNS, so we can run a burn-in test to be confident that the tests won't generate any problems during CI builds.
  • Rename some variables, improve some printing, make some fields readonly.
  • For fear of interference between tests, change when the application is built: it's built as the very last step, so there can't be any sharing of mutable values between tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team as a code owner January 13, 2025 10:33
@aws-cdk-automation aws-cdk-automation requested a review from a team January 13, 2025 10:33
@github-actions github-actions bot added the p2 label Jan 13, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 13, 2025
For the Aspect property tests, make some changes to make it easier
to see what's going on:

- Instead of just a visit log, keep a log of all actions: adding
  constructs, adding aspects, and visiting are now all part of the
  same time sequence with time steps so it's easier to reason about.
- Clearly mark timed steps with `t=0`, `t=1`, etc.
@rix0rrr rix0rrr force-pushed the huijbers/proptest-better-logging branch from ba94b40 to 530a018 Compare January 13, 2025 10:48
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (b021efe) to head (444739e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32884   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13698    13698           
  Branches     2413     2413           
=======================================
  Hits        11148    11148           
  Misses       2271     2271           
  Partials      279      279           
Flag Coverage Δ
suite.unit 81.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 13, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 444739e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 53c9d96 into main Jan 13, 2025
22 checks passed
@mergify mergify bot deleted the huijbers/proptest-better-logging branch January 13, 2025 12:50
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants