Skip to content

Conversation

@andyu17
Copy link
Contributor

@andyu17 andyu17 commented Jan 12, 2025

Issue # (if applicable)

None

Reason for this change

Fixed typos in code comments.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@andyu17 andyu17 requested a review from a team as a code owner January 12, 2025 01:31
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2025 01:31
@github-actions github-actions bot added the p2 label Jan 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 12, 2025
@moelasmar moelasmar changed the title docs(api): fix typos chore(docs): fix typos Jan 12, 2025
@moelasmar moelasmar removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 12, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 12, 2025
@codecov
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (899bc87) to head (a7f9dc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32861   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13695    13695           
  Branches     2412     2412           
=======================================
  Hits        11145    11145           
  Misses       2271     2271           
  Partials      279      279           
Flag Coverage Δ
suite.unit 81.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@moelasmar moelasmar added pr-linter/exempt-test The PR linter will not require test changes pr/needs-tests This PR is missing tests. and removed pr/needs-tests This PR is missing tests. pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jan 12, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 12, 2025
@moelasmar moelasmar added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr-linter/exempt-test The PR linter will not require test changes pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jan 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 12, 2025 06:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 88247b9 into aws:main Jan 12, 2025
18 of 19 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7f9dc0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants