Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 10, 2025

See CHANGELOG.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Reverts #32636

It leads to a problem in case of applications where there are no
top-level stacks, but only stacks in nested stages: #32836.

Closes #32836.
@rix0rrr rix0rrr added the pr/no-squash This PR should be merged instead of squash-merging it label Jan 10, 2025
@rix0rrr rix0rrr requested a review from a team as a code owner January 10, 2025 19:52
@github-actions github-actions bot added the p2 label Jan 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2025 19:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 10, 2025
Co-authored-by: Momo Kornher <[email protected]>
@rix0rrr rix0rrr added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 10, 2025 20:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 10, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5be52ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit afe6e87 into v2-release Jan 10, 2025
13 of 14 checks passed
@rix0rrr rix0rrr deleted the patch/v2.175.1 branch January 10, 2025 20:58
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants