Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Jan 10, 2025

Issue #32210

Closes #32210

Reason for this change

Incorrect grammar in a SnapStart warning that appears during cdk deployment.

Description of changes

Corrected the line:

SnapStart only support published Lambda versions. Ignore if function already have published versions

to:

SnapStart only supports published Lambda versions. Ignore if function already has published versions.

Describe any new or updated permissions being added

No permissions changes.

Description of how you validated changes

No testing needed, only changed text in a warning.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jan 10, 2025
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Jan 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2025 01:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@iankhou iankhou changed the title Fix snapstart warning grammar issue chore(lambda):fix snapstart warning grammar issue Jan 10, 2025
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (78fba23) to head (66b0317).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32829   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         222      222           
  Lines       13717    13717           
  Branches     2417     2417           
=======================================
  Hits        11183    11183           
  Misses       2254     2254           
  Partials      280      280           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.98% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@iankhou iankhou changed the title chore(lambda):fix snapstart warning grammar issue chore(lambda): fix snapstart warning grammar issue Jan 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 10, 2025 02:59

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 10, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 66b0317
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c3ff821 into main Jan 10, 2025
22 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the iankhou-snapstart-warning-grammar branch January 10, 2025 15:20
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda: SnapStart Warning

3 participants