chore: add metadata import and statement updater #32828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinZZ
changed the base branch from
main
to
yuanhaoz/feat/metadata-collection-1
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-2
branch
from
a74b3c0 to
9ffe3f8
Compare
aws-cdk-automation
previously requested changes
Jan 10, 2025
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
GavinZZ
changed the title
GavinZZ
changed the title
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-1
branch
from
ae763b0 to
f9f14d4
Compare
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-2
branch
from
9ffe3f8 to
be91a8f
Compare
GavinZZ
changed the title
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-2
branch
from
be91a8f to
02bb486
Compare
GavinZZ
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
GavinZZ
changed the base branch from
yuanhaoz/feat/metadata-collection-1
to
main
|
@mergify refresh |
✅ Pull request refreshed |
GavinZZ
changed the title
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Reason for this change
As a follow up to #32827. We need to add metadata statement to the constructor to every L2 constructs that inherits
Resourceclass. We usedts-morphas the typescript parser to parse all CDK files and find the constructs that match the requirements.Add import statement and
this.node.addMetadata(statement to the file.Description of changes
Main change is a one-time tool
metadata-updaterto automatically find the right classes and add import statements and add metadata statements. The tool can be run multiple times and should not add additional import or add metadata statements to files that already been added.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license