-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: add forceStdOut and remove quiet as options for assetPublishing #32824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kaizen Conroy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
e63b5e4 to
3e9cfd6
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
28c0fa3 to
9c5bb1d
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
|
Comments on closed issues and PRs are hard for our team to see. |
Related Issue: cdklabs/cdk-assets#196
Reason for this change
Essentially updating the plugin point between the cdk cli and cdk-assets to be reflective of the changes to cdk assets.
data()function which always prints to stdout in the CDK CLI. This is because shell logging messages today were previously printed to stdout directly by the cdk-assets shell, and this change preserves that funcionality.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license