Skip to content

Conversation

@HBobertz
Copy link
Contributor

@HBobertz HBobertz commented Jan 9, 2025

Related Issue: cdklabs/cdk-assets#196

Reason for this change

Essentially updating the plugin point between the cdk cli and cdk-assets to be reflective of the changes to cdk assets.

  • Added support for forceStdOut which logs the messages to the data() function which always prints to stdout in the CDK CLI. This is because shell logging messages today were previously printed to stdout directly by the cdk-assets shell, and this change preserves that funcionality.
  • Removed the now deprecated quiet flag, as it is no longer relevant.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@HBobertz HBobertz requested a review from a team as a code owner January 9, 2025 22:44
@github-actions github-actions bot added the p2 label Jan 9, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 9, 2025 22:44
@HBobertz HBobertz changed the title chore: add forceStdOut and remove quiet as options for assetPublishing events chore: add forceStdOut and remove quiet as options for assetPublishing Jan 9, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 9, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32824/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Base automatically changed from bobertzh/CliIoHost to main January 14, 2025 02:01
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32824/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@mrgrain mrgrain closed this Feb 11, 2025
@mrgrain mrgrain deleted the bobertzh/assetPublishing branch February 11, 2025 09:10
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-cli-test-run This PR needs CLI tests run against it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants