feat(rds): support SecondsUntilAutoPause for serverless instance
#32787
Conversation
github-actions
bot
added
valued-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
hassanazharkhan
changed the title
SecondsUntilAutoPause for serverless instanceSecondsUntilAutoPause for serverless instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32787 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 120 120
Lines 6933 6933
Branches 1169 1169
=======================================
Hits 5711 5711
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
1 similar comment
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
hassanazharkhan
force-pushed
the
32280
branch
from
b771e5e to
442aafa
Compare
hassanazharkhan
force-pushed
the
32280
branch
from
9e6bca7 to
1293628
Compare
…adjust related logic in cluster implementation and tests
…proved clarity and type consistency
| /** | ||
| * The number of seconds until a serverless cluster is paused. | ||
| */ | ||
| protected readonly secondsUntilAutoPause?: number; |
There was a problem hiding this comment.
nit: is this supposed to be Duration
| * @default undefined - RDS default setting is 300 seconds (five minutes). | ||
| * @see https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2-auto-pause.html | ||
| */ | ||
| readonly secondsUntilAutoPause?: Duration; |
There was a problem hiding this comment.
Looks like the ServerlessCluster has this property named as autoPause here. Since we can't change the name of that prop I'd prefer to keep the prop name consistent since they do the same thing. Maybe the same description as well?
|
|
||
| this.serverlessV2MaxCapacity = props.serverlessV2MaxCapacity ?? 2; | ||
| this.serverlessV2MinCapacity = props.serverlessV2MinCapacity ?? 0.5; | ||
| this.secondsUntilAutoPause = props.secondsUntilAutoPause?.toSeconds(); |
There was a problem hiding this comment.
If props.secondsUntilAutoPause is undefined will this.secondsUntilAutoPause be set to undefined or 0? I ask because in the ServerlessCluster version of this prop they check if its 0 and then set it to undefined here. I suspect this might be why the integ tests in the build are failing as well
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
@hassanazharkhan Are you able to make the suggested fixes from @aaythapa ? If not, I'd like to take a look. |
I'll get it fixed today, Thanks |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
Comments on closed issues and PRs are hard for our team to see. |
6 participants
Issue # (if applicable)
Closes #32280
Reason for this change
To introduce a support of Serveless Instances to be auto paused after certain interval.
Description of changes
Use to set
SecondsUntilAutoPauseto something other than the default of 5 minutes.Describe any new or updated permissions being added
No new IAM permissions.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license