Skip to content

chore(cli-integ): fix a race condition in the resource-pool tests #32646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

chore(cli-integ): fix a race condition in the resource-pool tests #32646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5676b83
chore(cli-integ): fix a race condition in the resource-pool tests
rix0rrr Dec 23, 2024
705c2e1
Merge branch 'main' into huijbers/fix-race
mergify[bot] Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/@aws-cdk-testing/cli-integ/test/resource-pool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,16 @@ const POOL_NAME = 'resource-pool.test';
test('take and dispose', async () => {
const pool = ResourcePool.withResources(POOL_NAME, ['a']);
const take1 = pool.take();
const take2 = pool.take();

let released = false;

const lease1 = await take1;

// We must start the take2 only after take1 has definitely
// succeeded, otherwise we have a race condition if take2 happens to
// win the race (we expect take1 to succeed and take2 to wait).
const take2 = pool.take();

// awaiting 'take2' would now block but we add an async
// handler to it to flip a boolean to see when it gets activated.
void(take2.then(() => released = true));
Expand Down
Loading