feat(ecs): add tls property to a ServiceConnectService

[ren-yamanashi]

Issue # (if applicable)

Closes #32583

Reason for this change

ServiceConnectService in ECS did not support the tls property.

Description of changes

• Added tls property to ServiceConnectService(interface) in ECS(BaseService)
• modified implementation to allow specifying ServiceConnectService tls in the enableServiceConnect method

Description of how you validated changes

Added unit tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (7b5f5a5) to head (c4fb13f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32605   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         232      232           
  Lines       14135    14135           
  Branches     2460     2460           
=======================================
  Hits        11428    11428           
  Misses       2427     2427           
  Partials      280      280           

Flag	Coverage Δ
suite.unit	80.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	79.64% <ø> (ø)
packages/aws-cdk-lib/core	82.17% <ø> (ø)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

dismiss auto review

[GavinZZ]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

(This review is outdated)

[ren-yamanashi]

Exemption Request

This MR does not implement integration testing for the following reasons.

1. AWS Private CA (PCA) is an expensive service and maintaining resources for testing is inefficient
2. existing aws-acmpca module does not have integration test too
3. test execution requires actual PCA, making it difficult to run in a CI environment

(This comment is based on a comment suggested at #32621)

[ren-yamanashi]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[ren-yamanashi]

@GavinZZ

The pr/needs-maintainer-review label seems to have been removed by aws-cdk-automation...

aws-cdk-automation removed pr/needs-maintainer-review

[GavinZZ]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[GavinZZ]

@GavinZZ

The pr/needs-maintainer-review label seems to have been removed by aws-cdk-automation...

aws-cdk-automation removed pr/needs-maintainer-review

It's removed because it's approved now by a maintainer so it's no longer in the state of needs-maintainer-review

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c4fb13f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.