Skip to content

Conversation

@go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jun 6, 2024

TODO

  • Design
    • I'm wondering if we should provide the properties onFailure and FailureConditions as per CFn or have a boolean type like autoRollback. I think customizing it for CDK is a good design, but given the recent CodePipeline trend and its CFn structure, there may be extensions to this in the future.
    • It is also possible to add a failureConditionsResult as an enum type to stageProps instead of onFailure (FailureConditions) to prevent nesting.
    • We could add the autoRollback property for now and deprecate it if the structure FailureConditions is needed in the future.
  • Verify with CFn and add validations if needed
    • if a stage is source stage
    • if a pipeline type is NOT V2
  • unit tests
  • integ tests
  • README
  • Change the PR title if needed and this description

Issue # (if applicable)

Closes #30083.

Reason for this change

Description of changes

WIP

Description of how you validated changes

WIP

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 6, 2024 03:45
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 6, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 450a609
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra
Copy link
Contributor

I think that we are getting too many features that are only available on pipelines v2 to keep adding properties to the same construct. It's probably time that we make a PipelineV2 instead of just adding more props that only work in specific circumstances.

@go-to-k
Copy link
Contributor Author

go-to-k commented Jun 7, 2024

@TheRealAmazonKendra

I see. I think it is good to work on this issue after the V2 construct is completed, so I will close this PR for the time being.

@tvdijk
Copy link

tvdijk commented Oct 16, 2024

Hi, is there an issue I can follow for the V2 construct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_codepipeline: Rollbacks for CodePipelines

4 participants