fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix in fi… #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld names of reference paths * add suffix ".$" for the fields whose values are reference paths, including json path and context object * fix unit tests and integration test for lambda task fixes aws#2937
rix0rrr
reviewed
Jun 20, 2019
| @@ -101,7 +102,7 @@ export class StateGraph { | |||
| public toGraphJson(): object { | |||
| const states: any = {}; | |||
| for (const state of this.allStates) { | |||
| states[state.stateId] = state.toStateJson(); | |||
| states[state.stateId] = FieldUtils.renderObject(state.toStateJson()); | |||
There was a problem hiding this comment.
I feel like this should be the responsibility of the individual tasks. It only makes sense in the Parameters field, no?
There was a problem hiding this comment.
Yes, you are right. I forgot the reference path only applies for Parameters field, rather than the entire block of state.
* Add Qualifier in the list of supporting parameters for lambda * Increase unit test coverage for all the services which support "waitForTaskToken"
rix0rrr
approved these changes
Jun 21, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eld names of reference paths
fixes #2937
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.