Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eks): add private cluster reference link #29201

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Feb 21, 2024

Issue # (if applicable)

Reason for this change

EKS cluster with isolated VPC has been a gap for customers and now we have a working reference architecture at https://github.com/aws-samples/aws-cdk-examples/tree/master/java/eks/private-cluster I am adding a link in the aws-eks README hopefully to have more visibility.

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 21, 2024 16:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 21, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ded1964
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 21, 2024
Copy link
Contributor

mergify bot commented Feb 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 97e1cef into aws:main Feb 21, 2024
27 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 21, 2024
GavinZZ pushed a commit that referenced this pull request Feb 22, 2024
### Issue # (if applicable)



### Reason for this change

EKS cluster with isolated VPC has been a gap for customers and now we have a working reference architecture at https://github.com/aws-samples/aws-cdk-examples/tree/master/java/eks/private-cluster I am adding a link in the aws-eks README hopefully to have more visibility.



### Description of changes



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants