Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add clusterArn property to DatabaseCluster #29133

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

BenFradet
Copy link
Contributor

Issue # (if applicable)

Reason for this change

This is to bring parity with #10741, we need the cluster arn to enable data api manually waiting for #28574.

Description of changes

This adds a clusterArn property to IDatabaseCluster

Description of how you validated changes

The changes have been validated through a unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 16, 2024 10:46
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud pahud changed the title feat(rds): add clusterArn property to DatabaseCluster chore(rds): add clusterArn property to DatabaseCluster Feb 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 20, 2024 14:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2024
@@ -50,6 +50,11 @@ export interface IDatabaseCluster extends IResource, ec2.IConnectable, secretsma
*/
readonly engine?: IClusterEngine;

/**
* The ARN of the clusteDatabaseClusterr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: looks like the spelling got a little messed up here -- how about just "The ARN of the database cluster"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, don't know how that got there 😅

Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2024
@mergify mergify bot dismissed colifran’s stale review February 20, 2024 18:03

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2024
@affanc
Copy link

affanc commented Feb 20, 2024

Hello Team,
Another construct that should be supporting the Serverless v2 is:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_appsync.RdsDataSource.html

@affanc
Copy link

affanc commented Feb 23, 2024

@colifran any update on this issue. can cx try anything from their end to resolve this issue

@colifran
Copy link
Contributor

@affanc It seems like you're saying this same functionality should be replicated on the construct you linked? If that's the case, they should open an issue or they can create a PR to add the functionality they need.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8f500dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2f720a1 into aws:main Feb 29, 2024
10 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants